Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cats-effect to 3.0.0 #2351

Merged
merged 4 commits into from
Mar 30, 2021
Merged

Conversation

rkrzewski
Copy link
Contributor

Cats-effect 3.0.0 release is coming up soon, so I thought a PR updating that dependency might be in order.

The ecosystem will OSS library ecosystem will probably upgrade quickly, but applications may lag behind for a while, so maybe creating a separate elastic4s-effects-cats-2 module for providing compatibility with legacy cats-effect 2.x would be a good idea. Please let me know.

@rkrzewski
Copy link
Contributor Author

[info] *** 1 TEST FAILED ***
[info] DateRangeQueryHttpTest:
[info] a range query should 
[info] - support date math for gte *** FAILED ***
[info]   1 was not equal to 2 (DateRangeQueryHttpTest.scala:47)

Seems unrelated?

@sksamuel
Copy link
Collaborator

I think the idea of having two modules is best.

@sksamuel
Copy link
Collaborator

[info] *** 1 TEST FAILED ***
[info] DateRangeQueryHttpTest:
[info] a range query should 
[info] - support date math for gte *** FAILED ***
[info]   1 was not equal to 2 (DateRangeQueryHttpTest.scala:47)

Seems unrelated?

Yep, I will fix this, not related to anything.

@sksamuel
Copy link
Collaborator

If you want to move out of draft I will merge.

@rkrzewski
Copy link
Contributor Author

Cats-effect 3.0.0 final is planned for Sunday, 28th. I think it's reasonable to wait util then with merging.

@sksamuel
Copy link
Collaborator

sksamuel commented Mar 24, 2021 via email

@rkrzewski rkrzewski changed the title Update cats-effect to 3.0.0-RC2 Update cats-effect to 3.0.0 Mar 29, 2021
@rkrzewski rkrzewski marked this pull request as ready for review March 29, 2021 08:45
@rkrzewski
Copy link
Contributor Author

oops, I've added some some vscode and Metals files accidentally. Let me clean that up

@rkrzewski
Copy link
Contributor Author

OK, it's ready to merge.

@sksamuel sksamuel merged commit c9205b1 into Philippus:master Mar 30, 2021
@sksamuel
Copy link
Collaborator

I'll cut a 7.12 release with this later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants