Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to run 7.3, 7.4, or 8.0 #35

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Conversation

svpernova09
Copy link
Contributor

No description provided.

@svpernova09 svpernova09 merged commit c67b5e2 into master Aug 8, 2020
@svpernova09 svpernova09 deleted the add-php-versions branch August 8, 2020 19:22
@svpernova09
Copy link
Contributor Author

I got you some code @garak

Copy link

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. But 7.4 is superfluous here, since "^7.3" is including every 7 minor version above 7.2

@svpernova09
Copy link
Contributor Author

Good. But 7.4 is superfluous here, since "^7.3" is including every 7 minor version above 7.2

According to https://getcomposer.org/doc/articles/versions.md#caret-version-range-

Screen Shot 2020-08-10 at 16 25 14

I'm understanding this to mean our PHP versions as stated:

    "require": {
        "php": "^7.3||^7.4||^8.0"
    },

Will be translated as >=7.3 <7.4.0 OR >=7.4 <7.5.0 OR >=8.0 <8.1.0 which will allow any patch version of 7.3, 7.4, or 8.0 PHP release.

@garak
Copy link

garak commented Aug 11, 2020

You didn't read it carefully

@svpernova09
Copy link
Contributor Author

You didn't read it carefully

This is not a helpful comment.

@garak
Copy link

garak commented Aug 12, 2020

Just re-read it: you took the rules for zero versions as universal (they aren't).
Edit: I'll try to be more specific: ^7.3 means "at least 7.3.0 and below 8"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants