Don't ResizeCache on sector change if no filename is defined #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
DiskCache computes its size from a file. Skip ResizeCache Without file (i.e. 'empty' CD) Fixes PiSCSI#1426 Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
|
kkaempf
added a commit
to kkaempf/piscsi
that referenced
this pull request
Apr 2, 2024
…1438) * Add tests for issue#1426 Signed-off-by: Klaus Kämpf <kkaempf@gmail.com> * add test without medium Signed-off-by: Klaus Kämpf <kkaempf@gmail.com> * Don't resize DiskCache without a file DiskCache computes its size from a file. Skip ResizeCache Without file (i.e. 'empty' CD) Fixes PiSCSI#1426 Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
rdmark
added a commit
that referenced
this pull request
Apr 13, 2024
…ging (#1451) * Revert "Don't ResizeCache on sector change if no filename is defined (#1438)" This reverts commit dd9a329. * Revert "Add ModeSense page 0x25 (DEC special function control page) (#1412)" This reverts commit 1121b8d. * Revert "DiskCache needs a size" This reverts commit 7cc8df2. * Revert "Honor sector size change via ModeSelect6 in scsicd (#1406)" This reverts commit b7f65d3. * Revert "Multiple fixes for ModeSelect (#1405)" This reverts commit ad5eae9.
rdmark
pushed a commit
that referenced
this pull request
May 1, 2024
* Add tests for issue#1426 Signed-off-by: Klaus Kämpf <kkaempf@gmail.com> * add test without medium Signed-off-by: Klaus Kämpf <kkaempf@gmail.com> * Don't resize DiskCache without a file DiskCache computes its size from a file. Skip ResizeCache Without file (i.e. 'empty' CD) Fixes #1426 Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
rdmark
added a commit
that referenced
this pull request
May 1, 2024
…ging (#1451) * Revert "Don't ResizeCache on sector change if no filename is defined (#1438)" This reverts commit dd9a329. * Revert "Add ModeSense page 0x25 (DEC special function control page) (#1412)" This reverts commit 1121b8d. * Revert "DiskCache needs a size" This reverts commit 7cc8df2. * Revert "Honor sector size change via ModeSelect6 in scsicd (#1406)" This reverts commit b7f65d3. * Revert "Multiple fixes for ModeSelect (#1405)" This reverts commit ad5eae9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426