* Only attach event listener to timestamp catcher componenet from des…

…cription component
PikachuEXE · Dec 30, 2024 · b35f5f2 · b35f5f2
1 parent 7d16b4a
commit b35f5f2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/src/renderer/components/FtTimestampCatcher.vue b/src/renderer/components/FtTimestampCatcher.vue
@@ -1,7 +1,5 @@
 <template>
   <p
-    @click="onClick"
-    @keydown.space.prevent="onClick"
     @timestamp-clicked="catchTimestampClick"
     v-html="displayText"
   />
@@ -44,13 +42,7 @@ const displayText = computed(() => props.inputHtml.replaceAll(/(?:(\d+):)?(\d+):
   return `<a tabindex="${props.linkTabIndex}" href="${url}" onclick="event.preventDefault();this.dispatchEvent(new CustomEvent('timestamp-clicked',{bubbles:true,detail:${time}}));window.scrollTo(0,0)">${timestamp}</a>`
 }))
 
-const emit = defineEmits(['text-click', 'timestamp-event'])
-
-function onClick(e) {
-  // Ignore link clicks
-  if (e.target.tagName === 'A') { return }
-  emit('text-click')
-}
+const emit = defineEmits(['timestamp-event'])
 
 /**
  * @param {CustomEvent} event

diff --git a/src/renderer/components/WatchVideoDescription/WatchVideoDescription.vue b/src/renderer/components/WatchVideoDescription/WatchVideoDescription.vue
@@ -20,7 +20,7 @@
       :input-html="processedShownDescription"
       :link-tab-index="linkTabIndex"
       @timestamp-event="onTimestamp"
-      @text-click="expandDescription"
+      @click.native="expandDescriptionWithClick"
     />
     <span
       v-if="showControls && showFullDescription"
@@ -97,6 +97,16 @@ function onTimestamp(timestamp) {
   emit('timestamp-event', timestamp)
 }
 
+/**
+ @param {PointerEvent} e
+ */
+function expandDescriptionWithClick(e) {
+  // Ignore link clicks
+  if (e.target.tagName === 'A') { return }
+
+  expandDescription()
+}
+
 /**
  * Enables user to view entire contents of description
  */