Local Playlist v1

[PikachuEXE]

Created a milestone for it: https://github.com/PikachuEXE/FreeTube/milestone/1

Let's discuss what's left for that to be "finished" here and create issues for it

[PikachuEXE]

Summoning @efb4f5ff-1298-471a-8973-3d47447115dc

[efb4f5ff-1298-471a-8973-3d47447115dc]

#53 #52 #50 #48 have to be implemented

When looking at the issues from #44 (aside from the ones that are already implemented by u) i only think that maybe FreeTubeApp#1522 is a nice to have

[PikachuEXE]

Agreed on #53 #52 #50 #48

I won't add FreeTubeApp#1522 into initial PR
Too many things to review already

Might implement it if 0.20 is not urgent to be released

[efb4f5ff-1298-471a-8973-3d47447115dc]

You're right im fine with adding that in the future (I sometimes forget people wont get notified when u upvote a comment)

[kommunarr]

Discovered very minor visual bug (probably pre-existing in FT): selecting "Remove from history" on dropdown options of a video only appears to affect one instance of it, even when there are multiple duplicates on a given view (e.g., a playlist). This is just visual and corrects when route is refreshed. Interestingly, bug does not occur the other way with "Mark as Watched," which updates all duplicates instantaneously.

[PikachuEXE]

Please open an issue for it
Plus I will wait until FreeTubeApp#4017 merged before checking it

Seen #59 opened

[efb4f5ff-1298-471a-8973-3d47447115dc]

@PikachuEXE Is there something else to be done except for #57, #56?

[PikachuEXE]

Extract translations but that should be done after review and adjustments/fixes are done
Other stuff should be done after initial PR merged

[efb4f5ff-1298-471a-8973-3d47447115dc]

I'm pretty sure those issues are fixed. So i would suggest implementing extract translations and go ahead with creating the PR upstream

[efb4f5ff-1298-471a-8973-3d47447115dc]

Everything upstream that needed to be merged is merged so when translations are done u can open up the PR

[PikachuEXE]

Ya I saw FreeTubeApp#4066 merged
Just created FreeTubeApp#4234

[efb4f5ff-1298-471a-8973-3d47447115dc]

Only thing i noticed that we could look into before PR goes upstream:

Thumbnail 9 vs 10

10 is a bit more to the right vs 9. Cant remember that it looked like this. Not sure when this happened.

VirtualBoxVM_UFp3fRjPJ1.mp4

[PikachuEXE]

That issue exists before this change...
It should be fixed in main repo instead of playlist branch
I will look into it but it's not part of playlist v1

[PikachuEXE]

FreeTubeApp#4179