update : Updated showTopModalSheet to include borderRadius customization #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title: Add radius support for TopModalSheet
Description:
This PR addresses issue #5 by adding support for customizing the border radius of the TopModalSheet function. It introduces a new optional
borderRadiusparameter that allows developers to specify the desired border radius for the modal sheet.Changes Made:
borderRadiusparameter to theshowTopModalSheetfunction.showTopModalSheetimplementation to handle theborderRadiusparameter and apply the specified border radius to the modal sheet.borderRadiusparameter.Why:
The motivation behind this change is to provide more flexibility and customization options for developers using the TopModalSheet function. By allowing the border radius to be adjusted, developers can create modal sheets that better align with their app's design aesthetic.
Result:
By incorporating this enhancement, developers can easily create TopModalSheets with custom border radius, enhancing the visual appeal and user experience of their Flutter apps.
Please review and merge this PR at your convenience. Thank you!