Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shouldSendOrder to ShipmatePluginConfig #500
Added shouldSendOrder to ShipmatePluginConfig #500
Changes from 2 commits
dc7b7d0
78b09d4
9694c87
aa1d5eb
55b516d
f151dbb
d2b636d
fef6288
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shipmentRequest is never assigned in the Nock request, so this test will always pass. The test below is doing it correctly:
shipmentRequest = reqBody;
Maybe it makes sense to make a global
shipmentRequests
and a global Nock that catches all shipmetn request. So, not per testcase. here we would store all shipment requests in this test suite. We can then do this:shipmateRequests[0]
. This way we are sure the logic of sending worksshipmateRequests
still only has 1 request.What do you think?