feat(admin-social-auth): privacy policy #515
Conversation
WalkthroughThe pull request introduces several updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
packages/vendure-plugin-admin-social-auth/package.jsonis excluded by!**/*.json
📒 Files selected for processing (5)
- packages/vendure-plugin-admin-social-auth/CHANGELOG.md (1 hunks)
- packages/vendure-plugin-admin-social-auth/README.md (1 hunks)
- packages/vendure-plugin-admin-social-auth/src/api/google-auth-strategy.ts (1 hunks)
- packages/vendure-plugin-admin-social-auth/src/ui/login.html (3 hunks)
- packages/vendure-plugin-admin-social-auth/test/dev-server.ts (0 hunks)
💤 Files with no reviewable changes (1)
- packages/vendure-plugin-admin-social-auth/test/dev-server.ts
✅ Files skipped from review due to trivial changes (1)
- packages/vendure-plugin-admin-social-auth/CHANGELOG.md
🧰 Additional context used
🪛 Markdownlint
packages/vendure-plugin-admin-social-auth/README.md
68-68: null
Bare URL used(MD034, no-bare-urls)
🔇 Additional comments (2)
packages/vendure-plugin-admin-social-auth/README.md (1)
51-66: Good addition.New section on Admin UI branding is helpful.
packages/vendure-plugin-admin-social-auth/src/api/google-auth-strategy.ts (1)
86-88: Good privacy move.Removing the email from the log is smart. It's safer and still tells us what we need to know.
| }), | ||
| ``` | ||
|
|
||
| The same goes for customizing the logo on the login page: https://docs.vendure.io/guides/extending-the-admin-ui/admin-ui-theming-branding/#specifying-custom-logos |
There was a problem hiding this comment.
Fix bare URL.
Wrap the URL in angle brackets.
🧰 Tools
🪛 Markdownlint
68-68: null
Bare URL used(MD034, no-bare-urls)
| @click="open = false" | ||
| > | ||
| <div class="modal"> | ||
| <span class="close">×</span> |
There was a problem hiding this comment.
Add click handler to the close button to enable modal dismissal
The close button doesn't have a click handler, so clicking it won't close the modal.
Apply this fix:
-<span class="close">×</span>
+<span class="close" @click="open = false">×</span>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <span class="close">×</span> | |
| <span class="close" @click="open = false">×</span> |
| @@ -6,10 +6,12 @@ | |||
| </title> | |||
| <link rel="icon" type="image/x-icon" href="/admin/favicon.ico" /> | |||
| <script src="https://accounts.google.com/gsi/client" async></script> | |||
| <script src="//unpkg.com/alpinejs" defer></script> | |||
There was a problem hiding this comment.
Specify HTTPS in script source for Alpine.js
The script source for Alpine.js should explicitly use HTTPS to ensure secure loading over a secure connection.
Apply this fix:
-<script src="//unpkg.com/alpinejs" defer></script>
+<script src="https://unpkg.com/alpinejs" defer></script>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <script src="//unpkg.com/alpinejs" defer></script> | |
| <script src="https://unpkg.com/alpinejs" defer></script> |
Description
Added privacy policu on the login screen for Google OAuth approval
Screenshots
Checklist
📌 Always:
👍 Most of the time:
📦 For publishable packages:
package.jsonCHANGELOG.mdSee this example