Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): add meta data into the OCI artifacts #186

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

wuhuizuo
Copy link
Contributor

The delivery jobs can utilize the meta data to publish TiUP packages, etc...

Signed-off-by: wuhuizuo wuhuizuo@126.com

The delivery jobs can utilize the meta data to publish TiUP packages, etc...

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind December 25, 2023 09:41
Copy link

ti-chi-bot bot commented Dec 25, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Review for PR "feat(packages): add meta data into the OCI artifacts"

Summary

This PR adds meta data into the OCI artifacts of the TiUP packages. The meta data includes OS, architecture, profile and version information.

Changes Made

  • packages.yaml.tmpl: Add meta data for each TiUP package
  • build-package-artifacts.sh.tmpl: Generate artifact-config.json with the meta data
  • gen-package-artifacts-with-config.sh: Add version field to the release-router.yaml

Potential Problems

There are no potential problems with this PR.

Suggestions

The code changes look good to me. I suggest adding some unit tests to ensure that the meta data is properly generated and included in the packages. Additionally, it would be helpful to update the project's documentation to reflect these changes.

@ti-chi-bot ti-chi-bot bot added the size/M label Dec 25, 2023
Copy link

ti-chi-bot bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijie0123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 25, 2023
Copy link

ti-chi-bot bot commented Dec 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-25 10:10:25.920427095 +0000 UTC m=+1474116.957654015: ☑️ agreed by lijie0123.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 039eaa2 into main Dec 25, 2023
1 of 2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/tiup-packages branch December 25, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants