Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pcakges): fix packages.yaml.tmpl for tiflow on v6.5.x versions #193

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jan 4, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Copy link

ti-chi-bot bot commented Jan 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Review of Pull Request: fix(pcakges): fix packages.yaml.tmpl for tiflow on v6.5.x versions

Summary

The pull request aims to fix the packages.yaml.tmpl file for tiflow on v6.5.x versions. The changes include updating the path of some files based on the .Release.version, using the semver.CheckConstraint function.

Changes Made

  • Updated paths of some files in packages.yaml.tmpl based on the .Release.version, using the semver.CheckConstraint function.

Potential Problems

There are no potential problems with this pull request.

Suggestions for Improvement

The pull request is good as it is. No improvements are necessary.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind January 4, 2024 08:12
@ti-chi-bot ti-chi-bot bot added the size/S label Jan 4, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jan 4, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 68b4f01 into main Jan 4, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tiflow-6.5.x branch January 4, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant