Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pcakges): fix packages.yaml.tmpl for tidb-operator on fips profile #194

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jan 5, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind January 5, 2024 05:38
Copy link

ti-chi-bot bot commented Jan 5, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request fixes the packages.yaml.tmpl file for tidb-operator on fips profile. It changes the profile section from [release] to [release, fips].

The changes seem straightforward and do not introduce any new potential problems. The changes made in the gen-package-artifacts-with-config.sh and gen-package-offline-package-with-config.sh files are only related to updating the output message of the scripts. The changes are appropriate and do not harm the code quality.

I would suggest the following improvements:

  1. Add more descriptive commit messages.
  2. Include more details in the PR description, such as the reason for the change and any relevant issue or discussion.
  3. Double-check that these changes work correctly in the intended environment by running the tests.

@ti-chi-bot ti-chi-bot bot added the size/S label Jan 5, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jan 5, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0ea11a9 into main Jan 5, 2024
1 of 2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tidb-operator-fips branch January 5, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant