Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): fix builders for tidb-tools #204

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind January 11, 2024 08:55
Copy link

ti-chi-bot bot commented Jan 11, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request diff, the key change is in the builders section of the packages.yaml.tmpl file. The change updates the builders for tidb-tools package with different versions of images for different versions of tidb.

There are no potential problems with the code changes in this pull request.

However, it would be better if the pull request description provided more context about why the changes were made. Additionally, it would be useful to have tests for the tidb-tools package to ensure that the updated builders are working as expected.

As a suggestion, the pull request description could be updated to provide more context, and the contributor could add tests for the tidb-tools package to ensure the changes work as expected.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 11, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit 85ec50a into main Jan 11, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/builder-for-tidb-tools branch January 11, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant