Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build grafana without pull #210

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat: build grafana without pull #210

merged 1 commit into from
Jan 17, 2024

Conversation

jayl1e
Copy link
Contributor

@jayl1e jayl1e commented Jan 17, 2024

Why:

  • fetch file usually 403

Copy link

ti-chi-bot bot commented Jan 17, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it seems that the main goal of this change is to build Grafana without pulling a specific file that usually results in a 403 error.

Looking at the diff, we can see that the change involves modifying the build steps to export a couple of environment variables and run a new target called "grafana_without_pull". It appears that this new target is meant to handle the build process without pulling the problematic file.

One potential problem with this change is that we don't know what the problematic file is or why it causes a 403 error. Without this context, it's hard to determine if this change is a proper solution or if it's just masking a more significant problem. It would be helpful to have more information about the root cause of the issue and why this new target is the best solution.

Another issue is that the new target name is not very descriptive. It's not clear what this target does or how it differs from the previous one. Providing more information in the target name or adding a comment could make it easier for future readers to understand the code.

Lastly, it would be a good idea to add some tests to ensure that the new build process works correctly and that the problematic file is no longer causing issues.

Overall, this change seems reasonable, but it would be helpful to have more context and tests. Here are some suggestions for improvements:

  • Add a comment explaining why the problematic file causes a 403 error and why this new target is the best solution.
  • Rename the new target to something more descriptive, like "build_grafana_without_problematic_file".
  • Add tests to ensure that the new target works correctly and that the problematic file is no longer causing issues.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 17, 2024
Copy link

ti-chi-bot bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 17, 2024
Copy link

ti-chi-bot bot commented Jan 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-17 09:02:04.205749303 +0000 UTC m=+346565.770046993: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit 52ba379 into main Jan 17, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/grafana branch January 17, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants