Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use simple golang builder for monitor #211

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat: use simple golang builder for monitor #211

merged 1 commit into from
Jan 17, 2024

Conversation

jayl1e
Copy link
Contributor

@jayl1e jayl1e commented Jan 17, 2024

Why:

  • monitoring has no compiling steps, so simply use one builder
  • need wget

Copy link

ti-chi-bot bot commented Jan 17, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Review for Pull Request - feat: use simple golang builder for monitor

Summary

The pull request aims to improve the builder for the monitor by using a simple golang builder. The change is made in the file packages/packages.yaml.tmpl. The existing builders are being replaced with a single builder golang:1.21.6.

Potential Problems

There are no apparent potential problems with this pull request.

Suggestions

The changes in this pull request look good and it seems like the change will not introduce any issues. However, it is always good practice to test the changes thoroughly before merging the pull request. Also, it would be good to update the documentation if necessary.

Overall

Overall, the changes in this pull request look good and seem to be beneficial. The code can be merged after thorough testing.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 17, 2024
Copy link

ti-chi-bot bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-17 09:50:04.522845579 +0000 UTC m=+349446.087143276: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit cb817b7 into main Jan 17, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/grafana branch January 17, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants