Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tiflow engine image artifact #222

Merged
merged 3 commits into from
Jan 26, 2024
Merged

feat: add tiflow engine image artifact #222

merged 3 commits into from
Jan 26, 2024

Conversation

jayl1e
Copy link
Contributor

@jayl1e jayl1e commented Jan 25, 2024

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from purelind January 25, 2024 10:56
Copy link

ti-chi-bot bot commented Jan 25, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
The pull request adds a new container image artifact for the tiflow engine. The change includes adding the necessary configuration in the packages.yaml.tmpl file.

Potential problems:

  • The PR description is empty, which makes it difficult to understand the purpose of the PR and its context.
  • It is not clear why the GOPROXY environment variable is set to multiple values. It might cause issues if the build process tries to resolve dependencies from different sources.

Suggestions:

  • The PR description should provide a brief summary of the changes and why they are necessary.
  • It would be helpful to include some information about the tiflow engine and its purpose.
  • The GOPROXY environment variable should be set to a single value to avoid any issues.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo January 25, 2024 10:56
@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-25 11:29:28.885539316 +0000 UTC m=+1046610.449837021: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 25, 2024
@wuhuizuo
Copy link
Contributor

/hold

@jayl1e
Copy link
Contributor Author

jayl1e commented Jan 26, 2024

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 5229d13 into main Jan 26, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feat/tiflow-docker branch January 26, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants