Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix build-package-images.sh.tmpl" #225

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

Reverts #224

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind January 26, 2024 08:47
Copy link

ti-chi-bot bot commented Jan 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the Pull Request title and description, it seems that this PR is reverting a previous change that was made to the build-package-images.sh.tmpl file. The diff shows that the only change that is being made is to remove the --cache-run-layers flag from the kaniko_executor_global_options variable.

Potential problems:

  • It is not clear from the description why this change is being reverted. If there was a specific issue with the previous change, it would be helpful to include that information in the description.
  • Removing the --cache-run-layers flag may impact the performance of the build process. It would be helpful to have more context around why this flag was originally added and why it is now being removed.

Fixing suggestions:

  • If there was a specific issue with the previous change, it would be helpful to include that information in the description so that reviewers can better understand why this change is being reverted.
  • If there was no specific issue with the previous change, it may be worth considering adding the --cache-run-layers flag back in and investigating any performance impacts separately.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 26, 2024
Copy link

ti-chi-bot bot commented Jan 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the diff provided, this pull request is reverting a previous change that was made to the build-package-images.sh.tmpl file. Specifically, it is reverting the change to the kaniko_executor_global_options variable, which set the --cache-run-layers flag to true. The reverted change sets the flag to false.

There is not enough context provided in the pull request description to identify any potential problems with the reverted change. However, based on the diff, it appears that the original change may have been made to improve performance by caching run layers. Reverting the change would likely result in slower build times.

If there was a specific reason for the original change, it would be good to address that reason before reverting the change. If there is no specific reason for the original change, then it may be better to keep the new value of the kaniko_executor_global_options variable.

Therefore, it is recommended to clarify the reason for the original change, and make sure that reverting it will not cause any new problems.

Copy link

ti-chi-bot bot commented Jan 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it seems like this pull request is reverting a previous change. The diff shows that the change being reverted modified the kaniko_executor_global_options variable in the build-package-images.sh.tmpl file. Specifically, the --cache-run-layers option was changed from being enabled to disabled.

Potential problems:

  • Without knowing the reason why the previous change was made, it's hard to determine if reverting it will cause any problems.

Fixing suggestions:

  • If possible, it would be good to investigate why the previous change was made and determine if it's still necessary. If it's not necessary, then reverting it is fine.
  • If the previous change is necessary, then it should be kept and not reverted.

@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 26, 2024
@wuhuizuo wuhuizuo merged commit c984086 into main Jan 26, 2024
1 of 2 checks passed
@wuhuizuo wuhuizuo deleted the revert-224-wuhuizuo-patch-1 branch January 26, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant