Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): add image copy rules #230

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Feb 5, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind February 5, 2024 04:39
Copy link

ti-chi-bot bot commented Feb 5, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Summary

This pull request adds image copy rules to packages/delivery.yaml. The changes include defining source repositories and specifying the tags_regex, dest_repositories, and constant tags for each source repository.

Potential Problems

  • The description for the image_copy_rules is not clear enough. It would be helpful to add more information about the purpose of the image_copy_rules.
  • It is not clear if the tags_regex pattern is correct for the hub.pingcap.net/pingcap/tiproxy/image source repository. More information is needed to confirm this.

Fixing Suggestions

  • Add a more detailed description of the image_copy_rules and what they are used for. This will make it easier for others to understand the reason behind the changes.
  • Add more information about the tags_regex pattern for the hub.pingcap.net/pingcap/tiproxy/image source repository to ensure it is correct. This will help others to understand what tags are being matched and copied.

Overall, the changes appear to be well organized and clearly defined. With the suggested adjustments, this will be a useful addition to the project.

@ti-chi-bot ti-chi-bot bot added the size/S label Feb 5, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Feb 5, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit f0cde60 into main Feb 5, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/image-delivery branch February 5, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant