Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pingcap/monitoring): fix builders #261

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Mar 4, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind March 4, 2024 08:45
Copy link

ti-chi-bot bot commented Mar 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes involve updating the builders for the PingCAP monitoring package. Specifically, the builders now use different images depending on the version of the release being built. The new images are hosted on the ghcr.io registry.

One potential problem is that the if statements in the YAML file may not be valid. It's difficult to tell without more context, but if they are not valid, the build process may fail.

A possible fix for this issue would be to test the if statements locally before merging the pull request. Additionally, it may be helpful to add some comments to the YAML file explaining the purpose of the different images and the if statements.

Overall, the changes in this pull request seem reasonable and should improve the build process for the PingCAP monitoring package.

Copy link
Contributor Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot bot added the size/XS label Mar 4, 2024
Copy link

ti-chi-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit a26fbda into main Mar 4, 2024
1 of 2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/builder-for-monitoring branch March 4, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant