Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pingcap/monitoring): support build for tag creating triggers #262

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Mar 4, 2024

For example:
run: "./packages/scripts/gen-package-artifacts-with-config.sh monitoring darwin amd64 v7.1.1 release v8.0.0 ''"
output:

function build() {
    export TARGET=release-8.0
    export TARGET_OS=darwin TARGET_ARCH=amd64
    make grafana_without_pull
    make default -C ng-monitoring
    make output/prometheus
    echo "building finished."
}

Signed-off-by: wuhuizuo wuhuizuo@126.com

For example:
run: "./packages/scripts/gen-package-artifacts-with-config.sh monitoring darwin amd64 v7.1.1 release v8.0.0 ''"
output:
```bash
function build() {
    export TARGET=release-8.0
    export TARGET_OS=darwin TARGET_ARCH=amd64
    make grafana_without_pull
    make default -C ng-monitoring
    make output/prometheus
    echo "building finished."
}
```

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind March 4, 2024 09:07
Copy link

ti-chi-bot bot commented Mar 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of changes:
This pull request is adding a new feature to the pingcap/monitoring package. Specifically, it is adding support for building tag creating triggers. These changes are achieved by modifying the packages.yaml.tmpl file.

Potential problems:

  • The code changes look fine, but there are no tests provided. It is always recommended to add tests for any new features or changes to the code.
  • It is unclear from the pull request description what the expected behavior of this feature is and how it should be used. Some additional documentation or examples would be helpful.

Fixing suggestions:

  • Add tests to ensure the new feature is working as intended.
  • Add more detailed documentation on how to use the new feature and expected behavior.
  • Consider adding some comments in the code to help explain what the changes are doing.

@ti-chi-bot ti-chi-bot bot added the size/XS label Mar 4, 2024
Copy link
Contributor Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

ti-chi-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4ff2b60 into main Mar 4, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/monitoring/support-build-for-tags branch March 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant