-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dockerfiles/cd/builders): add builder image for tidb-operator #338
Conversation
This pull request adds a new builder image for tidb-operator in the dockerfiles/cd/builders directory. The changes include adding a new image to the existing skaffold.yaml file and creating a new Dockerfile for the tidb-operator. The potential problem is that the PR does not provide any information about the testing process and the results of the testing. Therefore, it is suggested to add a section about the testing process and the results of the testing as part of the PR description. Additionally, the PR could benefit from a detailed explanation of the reasoning behind the changes, such as why a new builder image was needed and how it will improve the overall CI/CD process. The fixing suggestions are as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
8ad892c
to
2594b69
Compare
Based on the pull request title and description, the key change is adding a new builder image for tidb-operator. The changes include adding a new Dockerfile for tidb-operator, updating the One potential problem is that there is no explanation of why this change is necessary. Is there a specific need for a new builder image for tidb-operator? Without this information, it is difficult to assess the necessity of the change. Another potential problem is that the To address these issues, the pull request could be updated to include a brief explanation of why the new builder image is necessary. Additionally, the changes to the Overall, the changes look straightforward and the code appears to be well-organized and easy to read. |
Summary: Potential problems:
Fixing suggestions:
|
This pull request adds a new builder image for There are no potential problems identified in this pull request, as it only adds a new image and does not make any changes to existing code. Some suggestions for improvement include:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wuhuizuo wuhuizuo@126.com