Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: temp disable build for tiflash builder image #343

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jul 3, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

We can revert it after pingcap/tiflash#9178 be merged.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind July 3, 2024 08:28
Copy link

ti-chi-bot bot commented Jul 3, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

From the pull request title and description, it seems that the change is to temporarily disable the build for the tiflash builder image. The actual changes are in the pull-cd-builder-images.yaml and release-cd-builder-images.yaml files. The changes are to comment out the builder-tikv-fips module in the matrix section of both files. This means that the builder-tikv-fips module will not be built and released until the comment is removed.

As for potential problems, it's hard to tell without knowing the reason for disabling the build for the tiflash builder image. If there is a critical issue that needs to be addressed before building and releasing the builder-tikv-fips module, then the change is fine. However, if there is no critical issue, it's important to make sure that the builder-tikv-fips module is eventually built and released.

As for fixing suggestions, if the reason for disabling the build is not critical, it might be better to find a way to address the issue while still building and releasing the builder-tikv-fips module. Alternatively, if disabling the build is necessary, it might be helpful to add a comment explaining the reason for disabling the build and when it will be re-enabled.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jul 3, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jul 3, 2024

/approve

Copy link

ti-chi-bot bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit b84541a into main Jul 3, 2024
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the fix/temp-disable-tiflash branch July 3, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant