-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate linux builder OS from CentOS 7 to RockyLinux 8 #381
Conversation
This pull request is titled "Migrate linux builder OS from CentOS 7 to RockyLinux 8". The main changes in this pull request are updating the base image for the Dockerfiles in the There do not appear to be any obvious problems with this pull request. The changes are straightforward and appear to be well-contained within the affected Dockerfiles. However, there are a couple of suggestions for improvement:
Overall, this pull request appears to be a straightforward and well-executed migration from CentOS 7 to RockyLinux 8. |
This pull request migrates the Linux builder OS from CentOS 7 to RockyLinux 8 for several Dockerfiles. It replaces the CentOS base image with the RockyLinux base image for each Dockerfile. The new image is used to build the binaries for TiDB, TiKV, TiFlash, PD, TiDB Dashboard, and TiFlow. It also updates the Golang version from 1.21.6 to 1.21.13 for the PD Dockerfile. Overall, this pull request looks good, and the changes seem straightforward. However, there are a few potential problems that need to be addressed before merging this pull request. First, the new OS version may affect the dependencies required by the projects. The dependencies may be different from those used in CentOS 7. Therefore, it is necessary to ensure that the new dependencies are compatible with the projects. Second, the build process may take longer due to the new base image's size or different package management tools. The build time should be monitored to ensure that it does not significantly increase. Third, the new image may introduce new security vulnerabilities that were not present in CentOS 7. Therefore, it is essential to perform a security audit on the new image. Finally, we need to ensure that the Dockerfiles are backward compatible with the CentOS 7 base image. If any issues arise, we should fix them before merging this pull request. To address these potential problems, I suggest the following:
Once these issues are addressed, this pull request should be ready for merge. |
/just msb-tidb |
Fixes #379 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
b13ad00
to
eef70c7
Compare
The pull request proposes to migrate the base operating system of the builder images from CentOS 7 to Rocky Linux 8. The changes are made to the Dockerfiles of several builder images by updating the base image to use Rocky Linux 8 and making minor adjustments to the packages that are installed. Potential problems:
Fixing suggestions:
Overall, the changes proposed in the pull request seem reasonable, but caution should be exercised to ensure a smooth transition. |
/just msb-tidb |
2 similar comments
/just msb-tidb |
/just msb-tidb |
Signed-off-by: wuhuizuo <wuhuizuo@126.com> Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
The pull request titled Key Changes:
Potential Problems:
Fixing Suggestions:
|
…ntos 7 to rocky linux 8 The ones are compatible with centos 7 - ng-monitoring - tidb - tiflow The ones are NOT compatible with centos 7 - pd - tidb-dashboard Signed-off-by: wuhuizuo <wuhuizuo@126.com>
This pull request aims to migrate the Linux builder OS from CentOS 7 to RockyLinux 8. Here are the key changes:
Here are potential problems and suggestions:
Overall, I recommend that the changes are thoroughly tested to ensure stability and compatibility with the new OS and the updated dependencies. Make sure the changes in the Github Actions and package.yaml.tmpl file align with your CI/CD process. |
…om centos 7 to rocky linux 8 use the ubi edition base image.
Title: Migrate linux builder OS from CentOS 7 to RockyLinux 8 Key Changes:
Potential Problems:
Fixing Suggestions:
|
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
This PR is about migrating the Linux builder OS from CentOS 7 to Rocky Linux 8. Key changes of this PR include:
Potential problems:
Fixing suggestions:
|
/just msb-tikv |
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
f1f258c
to
238dea0
Compare
Key Changes:
Potential Problems:
Fixing Suggestions:
|
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Key Changes:
Potential Problems:
Fixing Suggestions:
|
Fixes #379 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
This pull request titled Key changes include:
Potential problems:
Fixing suggestions:
|
The pull request titled "Migrate linux builder OS from CentOS 7 to RockyLinux 8" aims to update the OS for the Linux builder from CentOS 7 to RockyLinux 8. Below are the main changes:
Potential problems:
Fixing suggestions:
|
…c++ install into /usr/lib64 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
The pull request aims to migrate the Linux builder OS from CentOS 7 to RockyLinux 8 in the CI/CD pipeline. Key Changes:
Potential Problems:
Fixing Suggestions:
|
We should merge it after we create a new repo release. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #379