-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dockerfiles/cd/builders/tiflash): upgrade openssl with conda pre-build package #395
Conversation
Based on the pull request title and description, the key changes are upgrading OpenSSL with a conda pre-build package in a Dockerfile. The diff shows that the changes are only made to the There are a few potential problems with the changes made in this pull request. Firstly, the new package is being installed from an external source ( To improve this pull request, it is recommended to use a more secure and version-controlled package source, such as an internal package repository or a trusted public repository. Additionally, it is recommended to add proper error handling for the |
…build package Signed-off-by: wuhuizuo <wuhuizuo@126.com>
a19f809
to
d742fd9
Compare
Based on the pull request title and description, the changes made in this pull request are upgrading openssl with a conda pre-build package in the Potential problems:
Fixing suggestions:
Overall, the changes look good, but adding test cases and clarifying the reason for not updating |
RUN --mount=type=cache,target=/var/cache/dnf \ | ||
dnf upgrade-minimal -y && \ | ||
dnf --enablerepo=powertools install -y git llvm-toolset cmake ninja-build openssl python3.12 libcurl-devel | ||
|
||
dnf --enablerepo=powertools install -y git llvm-toolset cmake ninja-build python3.12 libcurl-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desc: do not install the old openssl pkg.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wuhuizuo wuhuizuo@126.com