Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerfiles//cd/builders): bump golang version to v1.23.1 #418

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind September 18, 2024 07:35
Copy link

ti-chi-bot bot commented Sep 18, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes are:

  • The Golang version has been updated from v1.21 to v1.23.1 in various places such as Dockerfiles, workflows, and profiles.
  • The previous Golang versions (go-1.20 and go-1.19) have been removed from the profiles.

Potential problems:

  • There might be compatibility issues with the new Golang version and other dependencies, which could cause build failures.
  • The removal of the previous Golang versions from the profiles might break the compatibility of some images with the previous versions.

Suggested fixes:

  • Before merging the pull request, run some tests to ensure that the new Golang version is compatible with other dependencies.
  • To avoid breaking compatibility, it would be better to keep the previous Golang versions in the profiles. They can be removed after a grace period of a few weeks or months.

@ti-chi-bot ti-chi-bot bot added the size/M label Sep 18, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4c05774 into main Sep 18, 2024
17 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/renovate-anchor branch September 18, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant