Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(dockerfiles/bases): shrink base image size" #432

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

wuhuizuo
Copy link
Contributor

Reverts #431

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 23, 2024 09:04
Copy link

ti-chi-bot bot commented Sep 23, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that this is a revert of a previous change that was made in PingCAP-QE/artifacts#431.

Looking at the diff, it seems that the changes in this pull request are related to updating packages in various Dockerfiles. The changes involve updating the date and version number of the packages that are being installed, as well as removing the removal of the /var/cache/yum directory after installing packages.

As for potential problems, it's difficult to say without knowing the context of the previous change that was made in PingCAP-QE/artifacts#431. If that change was made to optimize the size of the Docker images, then this revert may result in larger image sizes.

If the changes in this pull request are deemed necessary, then one suggestion could be to investigate alternative ways to optimize the size of the Docker images without removing the /var/cache/yum directory. Alternatively, if the changes in PingCAP-QE/artifacts#431 were deemed unnecessary, then the revert in this pull request may be appropriate.

@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f092cd5 into main Sep 23, 2024
8 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-431-fix/shrink-base-image-size branch September 23, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant