Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pingcap/tidb-operator): fix builder for new release #438

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind September 26, 2024 03:28
Copy link

ti-chi-bot bot commented Sep 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request diff, it seems that the changes are related to the tidb-operator builder image. Specifically, the pull request is updating the builder image for new releases. The old image is being replaced with a new one for versions greater than or equal to 1.6.0-0, and the old image is retained for versions less than 1.6.0-0.

As for potential problems, it's hard to say without more information on the tidb-operator and its dependencies. However, if the new builder image has any breaking changes, it could cause issues with the deployments that use tidb-operator.

As for fixing suggestions, it's a good practice to test the updated tidb-operator with the new builder image before merging the pull request. This can be done by deploying tidb-operator to a staging environment and running some basic tests. Additionally, it might be useful to update the pull request description with more details, such as the reason for the change and any additional testing that was performed.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 26, 2024
@@ -1418,7 +1418,10 @@ components:
- {{ strings.ReplaceAll "/" "-" .Git.ref | strings.ToLower }}
- {{ .Release.version }}
builders:
- image: ghcr.io/pingcap-qe/cd/builders/tidb-operator:v20240325-91-g4bdc4c6
- if: {{ semver.CheckConstraint ">= 1.6.0-0" .Release.version }}
image: ghcr.io/pingcap-qe/cd/builders/tidb-operator:v20240901-43-g84787ec
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go version: 1.23.1

@wuhuizuo
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2024
Copy link

ti-chi-bot bot commented Sep 26, 2024

@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 13a841a into main Sep 26, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tidb-operator-builder branch September 26, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants