-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pingcap/tidb-operator): fix builder for new release #438
Conversation
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Based on the pull request diff, it seems that the changes are related to the As for potential problems, it's hard to say without more information on the As for fixing suggestions, it's a good practice to test the updated |
@@ -1418,7 +1418,10 @@ components: | |||
- {{ strings.ReplaceAll "/" "-" .Git.ref | strings.ToLower }} | |||
- {{ .Release.version }} | |||
builders: | |||
- image: ghcr.io/pingcap-qe/cd/builders/tidb-operator:v20240325-91-g4bdc4c6 | |||
- if: {{ semver.CheckConstraint ">= 1.6.0-0" .Release.version }} | |||
image: ghcr.io/pingcap-qe/cd/builders/tidb-operator:v20240901-43-g84787ec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go version: 1.23.1
/approve |
@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc, wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wuhuizuo wuhuizuo@126.com