Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerfiles/ci/base): fix open-jdk installation #439

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

wuhuizuo
Copy link
Contributor

install jdk rather than jre

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 27, 2024 06:26
Copy link

ti-chi-bot bot commented Sep 27, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change is that the installation of OpenJDK has been fixed to install JDK instead of JRE. This change is reflected in the Dockerfile by modifying the installation command to install java-${JAVA_VER}-openjdk-devel instead of java-${JAVA_VER}-openjdk.

There don't seem to be any potential problems with this change, as it's just a small fix to ensure that the correct version of OpenJDK is being installed.

One suggestion to improve the pull request would be to include a brief explanation or justification for the change in the pull request description. This would help other contributors understand the reasoning behind the change and potentially avoid confusion in the future.

Overall, this is a simple and straightforward pull request that addresses an issue with the OpenJDK installation in the Dockerfile. The change looks good and can be approved.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 27, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 07d1689 into main Sep 27, 2024
8 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wuhuizuo-patch-1 branch September 27, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant