fix(dockerfiles/cd/builders): install findutils package in builder

[wuhuizuo]

Signed-off-by: wuhuizuo wuhuizuo@126.com

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the diff provided, the key change in this pull request is the installation of the findutils package in both pd and tidb Dockerfiles. This package is required for the find command that is used in the build process.

There are no potential problems identified in this pull request.

However, one suggestion for improvement is to provide a more detailed explanation in the pull request description about why the findutils package is needed and how it affects the build process. This can help other developers understand the reasoning behind the change and avoid unnecessary confusion in the future.

Another potential suggestion is to run some tests after merging the pull request to ensure that the build process still works as expected with the findutils package installed. This can help catch any potential issues that may arise from the change.

Overall, this is a simple and straightforward change that should be easy to merge.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request diff, the key change is the addition of findutils package installation in the pd and tidb builders Dockerfile.

There don't seem to be any potential problems with this pull request. The change is straightforward and does not break any existing functionality.

However, there are a few suggestions for improvement:

• Update the PR description to include more information on why the findutils package is needed. This will help other developers understand the context of the change.
• Consider adding a comment in the Dockerfile explaining why findutils is being installed. This will help future developers understand the reason for this package installation.

[wuhuizuo]

I tested in commit: 6bf8b2e

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request description and diff, the key change is the addition of the findutils package to the Dockerfiles for the pd and tidb builders.

There are no potential problems identified in this pull request.

However, it is good to provide some suggestions to improve the pull request. For example, it would be helpful to provide more context and explanation in the pull request description, such as why the findutils package is needed. Additionally, it would be good to provide more detailed information in the commit message about the specific changes made and why they were necessary.

Finally, it is always good to run tests and make sure the changes have not introduced any unforeseen issues.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the author has added the findutils package to the Dockerfile for the pd and tidb builders.

The diff shows that the findutils package is added to the Dockerfiles for both pd and tidb builders, and the GOLANG_VERSION argument is updated from 1.21.13 to 1.23.2 in the pd builder.

There don't seem to be any potential problems with this PR, as adding the findutils package should not cause any issues, and updating the GOLANG_VERSION argument is a reasonable update.

However, it might be worth asking the author why they decided to add the findutils package and if they have tested the changes to ensure they don't break anything.

As for fixing suggestions, it might be worth adding a brief comment to the PR asking the author for more information on why they added the findutils package and if they have tested the changes. Other than that, the changes look good to be merged.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment