tikv: fix code coverage script

[glorv]

After this change we still need to wait tikv to update the rust toolchain to a newer version before this script can succeed due to rust-lang/rust#118850

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Key changes:

• The RUSTFLAGS environment variable has been updated from -Zinstrument-coverage to -C instrument-coverage.

Potential problems:

• The pull request mentions that the script may not succeed until Tikv updates the Rust toolchain to a newer version due to an issue with rust-lang/rust (#118850).
• The change itself does not seem to address any issue with the code coverage script, but rather just updates the flags used to compile Rust code.

Fixing suggestions:

• It may be worth clarifying in the pull request description whether the change is expected to address any issue with the script or if it is just a necessary update for future compatibility with Tikv and the Rust toolchain.
• If there are issues with the script, more context about the issue and any debugging efforts could be helpful to understand the motivation behind the change.

[glorv]

/cc @purelind @Connor1996

[ti-chi-bot]

@glorv: GitHub didn't allow me to request PR reviews from the following users: Connor1996.

Note that only PingCAP-QE members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @purelind @Connor1996

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[glorv]

/cc @overvenus

[Connor1996]

What's the difference

[glorv]

-Zinstrument-coverage is not supported anymore. -Z is for unstable flags

[Connor1996]

LGTM

[ti-chi-bot]

@Connor1996: changing LGTM is restricted to collaborators

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Key Changes:

This pull request is updating the tikv_ghpr_coverage.groovy script by changing the RUSTFLAGS environment variable from "-Zinstrument-coverage" to "-C instrument-coverage". This change is made to fix the code coverage script.

Potential Problems:

The pull request does not mention any potential problems. However, the pull request description indicates that the script will not work until tikv updates the rust toolchain to a newer version.

Fixing Suggestions:

The pull request looks good, but the contributor should add more information about the issue that the pull request is solving. Also, the contributor should mention the new version of rust that is required for this script to work. Additionally, it would be helpful to mention how the code coverage script was failing before this change.

[purelind]

/lgtm

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-01-17 09:47:48.791664744 +0000 UTC m=+349310.355962450: ☑️ agreed by purelind.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• jenkins/OWNERS [purelind]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment