Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update docker daemon verisonn to docker:20.10.24-dind #2820

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

purelind
Copy link
Collaborator

update docker daemon verisonn to docker:20.10.24-dind, to resolve the error encountered when starting the tidb container.

img_v3_028e_40fbacf4-6e77-44ad-8747-37a9484d5bfg

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and wuhuizuo February 26, 2024 10:02
Copy link

ti-chi-bot bot commented Feb 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review:

The pull request fixes an issue with the TiDB container by updating the docker daemon version to docker:20.10.24-dind. The description provides a clear context of the problem and how the update resolves it. The code changes are straightforward and only involve updating the container template.

Potential Problems:

No potential problems are identified in this pull request.

Fixing Suggestions:

No fixing suggestions are needed for this pull request. The changes are appropriate and have a clear purpose.

@purelind
Copy link
Collaborator Author

relate docker-library/golang#467

@ti-chi-bot ti-chi-bot bot added the size/XS label Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Overall, this pull request seems to be a straightforward fix that updates the Docker daemon version to resolve an error when starting the TiDB container. The changes made here are appropriate and should not introduce any issues.

One suggestion for improvement would be to provide more detail in the pull request description, such as the specific error that was encountered and how this change resolves it. Additionally, it may be helpful to explain why the specific version of Docker (20.10.24-dind) was chosen.

In terms of the code changes, the addition of environment variables for DOCKER_TLS_CERTDIR and DOCKER_REGISTRY_MIRROR seem appropriate, but it would be helpful to explain why they were added and how they impact the TiDB container.

Overall, this pull request seems to be a simple and appropriate fix, and I would recommend merging it once the suggested improvements have been made to the pull request description.

@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 8ffd694 into main Feb 26, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the purelind-patch-2 branch February 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants