Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(br): use failpoint tidb-server instead #2928

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Apr 19, 2024

Since pingcap/tidb#52734, we need to use failpoint tidb-server for br integration test

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Copy link

ti-chi-bot bot commented Apr 19, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the PR, it seems that the change is related to using a different failpoint for integration testing in the tidb-server binary. The change involves adding failpoint-enable and failpoint-disable to the make command in the merged_integration_br_test.groovy, pull_br_integration_test.groovy, release-7.1/pull_br_integration_test.groovy, release-7.5/pull_br_integration_test.groovy, and release-8.1/pull_br_integration_test.groovy files.

There are no potential problems with the change, as it seems to be a straightforward fix to use the correct failpoint for integration testing.

However, it might be a good idea to add some comments or documentation to explain why this change was necessary, and what impact it might have on the overall CI/CD pipeline.

As for fixing suggestions, it would be helpful to add some documentation to explain the change further. Additionally, it may be beneficial to test the changes locally before merging the PR to ensure that it works as expected.

@ti-chi-bot ti-chi-bot bot added the size/S label Apr 19, 2024
@purelind
Copy link
Collaborator

/cc @BornChanger

@ti-chi-bot ti-chi-bot bot requested a review from BornChanger April 19, 2024 06:00
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Apr 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 07:50:34.480217185 +0000 UTC m=+583653.591263630: ☑️ agreed by purelind.

Copy link

ti-chi-bot bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0108bca into PingCAP-QE:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants