Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(br): use failpoint tidb-server instead #2950

Merged

Conversation

purelind
Copy link
Collaborator

Since pingcap/tidb#52734, we need to use failpoint tidb-server for br integration test

Copy link

ti-chi-bot bot commented Apr 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request and the provided diff, the key change is that the make build_for_br_integration_test command has been replaced with (make failpoint-enable && make && make failpoint-disable) command. This change is made to use the failpoint tidb-server instead of the regular tidb-server.

There are no potential problems identified in the pull request. However, it is recommended to test the changes in a local environment before merging the pull request to ensure that the changes do not cause any issues.

As for fixing suggestions, it is recommended to add some information to the pull request description about how the changes were tested and provide some results or logs to support the changes. This would help the reviewer to have a better understanding of the changes and ensure that the changes meet the acceptance criteria.

Copy link

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit a0a6bb5 into PingCAP-QE:main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant