Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(apps/prod/tekton/configs): rename build pipelines and tasks #1382

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Changes

  1. drop old pipeline pingcap-build-package-darwin.
  2. rename pingcap-build-package-darwin-v2 to pingcap-build-package-darwin.
  3. drop old task pingcap-build-binaries-drawin.
  4. rename pingcap-build-binaries-drawin-v2 to pingcap-build-binaries-drawin.
  5. rename pipeline pingcap-build-package to pingcap-build-package-linux.
  6. rename task pingcap-build-binaries to pingcap-build-binaries-linux.

…p-build-package` `pingcap-build-package-linux`

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…ild-package-darwin

We upgraded to pingcap-build-package-darwin-v2, and the old pipeline is no longer used.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…rwin-v2 to pingcap-build-package-darwin

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…ild-binaries-darwin

We upgraded to pingcap-build-binaries-darwin-v2

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…s-darwin-v2 to pingcap-build-binaries-darwin

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…es to pingcap-build-binaries-linux

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 18, 2024 09:53
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Dec 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Key Changes:

  1. The old pipeline pingcap-build-package-darwin and task pingcap-build-binaries-darwin have been dropped, and the newer versions (pingcap-build-package-darwin-v2 and pingcap-build-binaries-darwin-v2) have been renamed to replace them. This indicates that the pipelines and tasks for building packages and binaries for the Darwin operating system have been updated.
  2. The pipeline pingcap-build-package and task pingcap-build-binaries have been renamed to pingcap-build-package-linux and pingcap-build-binaries-linux respectively. This indicates that these pipelines and tasks are specifically for building packages and binaries for the Linux operating system.
  3. The code for the pipeline pingcap-build-package-darwin has been modified. Notably, the boskos-server-url parameter has been added and the acquire-mac-machine task has been removed.
  4. References to the old pipelines and tasks in other files have been updated to refer to the new names.

Potential Problems:

  1. If there are any external scripts or configurations that reference the old pipeline and task names, they will break after this change.
  2. The removal of the acquire-mac-machine task in the pingcap-build-package-darwin pipeline may cause issues if this task was essential for the pipeline's operation.

Fixing Suggestions:

  1. Check all external scripts, configurations, or documentation that reference the old pipeline and task names, and update them to use the new names.
  2. If the acquire-mac-machine task was essential for the pingcap-build-package-darwin pipeline, consider adding it back or ensuring that its functionality is covered elsewhere in the pipeline.
  3. Make sure to thoroughly test the updated pipelines and tasks to ensure they are functioning as expected.

@ti-chi-bot ti-chi-bot bot added the size/XL label Dec 18, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 082ddbf into main Dec 18, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/dev-build-3 branch December 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant