Skip to content

Commit

Permalink
tf: Remove TF_DEBUG_RANGE, simplify internal implementation and make …
Browse files Browse the repository at this point in the history
…it robust to platforms where we get different instances of the _Node structure across shared library boundaries. Also make the TF_DEBUG environment variable apply to *all* TF_DEBUG_CODES, whether or not they are registered with TF_DEBUG_ENVIRONMENT_SYMBOL. This has been the source of confusing & hard to track down bugs.

Also remove the TF_DEBUG=list feature, which doesn't make sense in a modular world such as ours.

(Internal change: 2048962)
  • Loading branch information
gitamohr authored and pixar-oss committed Mar 12, 2020
1 parent e9711e8 commit ea8c17f
Show file tree
Hide file tree
Showing 6 changed files with 413 additions and 477 deletions.
14 changes: 0 additions & 14 deletions pxr/base/tf/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,6 @@ pxr_install_test_dir(
SRC testenv/baseline/TfDebugTestEnv
DEST TfDebugTestEnv/baseline
)
pxr_install_test_dir(
SRC testenv/baseline/TfDebugTestEnvList
DEST TfDebugTestEnvList/baseline
)
endif()
pxr_install_test_dir(
SRC testenv/baseline/TfDelegate
Expand Down Expand Up @@ -431,10 +427,6 @@ pxr_register_test(TfDebugFatal_3
COMMAND "${CMAKE_INSTALL_PREFIX}/tests/testTf TfDebugFatal_3"
EXPECTED_RETURN_CODE 134
)
pxr_register_test(TfDebugFatal_4
COMMAND "${CMAKE_INSTALL_PREFIX}/tests/testTf TfDebugFatal_4"
EXPECTED_RETURN_CODE 134
)
# These tests will depend on downstream libraries when built monolithic.
# We don't want changes to those libraries to affect test results so we
# simply disable these tests in that case.
Expand All @@ -445,12 +437,6 @@ pxr_register_test(TfDebugTestEnv
STDOUT_REDIRECT debugTestEnv.out
DIFF_COMPARE debugTestEnv.out
)
pxr_register_test(TfDebugTestEnvList
ENV TF_DEBUG=list
COMMAND "${CMAKE_INSTALL_PREFIX}/tests/testTf TfDebugTestEnvList"
STDOUT_REDIRECT debugTestEnvList.out
DIFF_COMPARE debugTestEnvList.out
)
endif()
pxr_register_test(TfDebugTestEnvHelp
ENV TF_DEBUG=help
Expand Down
Loading

0 comments on commit ea8c17f

Please sign in to comment.