Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlfPostPendingGLErrors can loop indefinitely when no GL context is invalid #198

Closed
meshula opened this issue Apr 16, 2017 · 2 comments
Closed

GlfPostPendingGLErrors can loop indefinitely when no GL context is invalid #198

meshula opened this issue Apr 16, 2017 · 2 comments

Comments

@meshula
Copy link
Member

meshula commented Apr 16, 2017

I ran into a minor issue here. If _context is null, because it wasn't initialized properly, the following code will loop indefinitely. A null _context is an error on my part, but I have code later to treat the problem.

		GlfGLContext::MakeCurrent(_context);
		GlfPostPendingGLErrors("make current");

c.f. http://stackoverflow.com/questions/31462770/glgeterror-returns-1282-infinitely

I suggest bailing out after a certain number of failures as suggested in the stack overflow thread.
@jtran56
Copy link

jtran56 commented Apr 17, 2017

Filed as internal issue #145407.

pixar-oss pushed a commit that referenced this issue Jun 29, 2017
@jacques-gasselin @pixar-oss
[Glf] Safeguard glGetError from infinite looping when
2facf5a 
an invalid GL context is used.

Fixes #198

(Internal change: 1759817)
@meshula meshula closed this as completed Jun 30, 2017
@meshula
Copy link
Member Author

meshula commented Jun 30, 2017

Thanks for the fix!

@Felix-Kit Felix-Kit mentioned this issue Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meshula @jtran56