Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UsdShadeOutput bool() doesn't check for attr definition #2876

Open
dgovil opened this issue Dec 18, 2023 · 1 comment
Open

UsdShadeOutput bool() doesn't check for attr definition #2876

dgovil opened this issue Dec 18, 2023 · 1 comment

Comments

@dgovil
Copy link
Collaborator

dgovil commented Dec 18, 2023 •
edited
Loading

Description of Issue

We're seeing an issue where UsdShadeOutputs aren't properly validated after a stage is dropped.

This appears to be because UsdShadeOutput::IsOutput doesn't mirror UsdShadeInput::IsInput validation. Specifically the attr && attr.IsDefined() is missing.

I can put up a PR shortly but wanted to file the issue first.

(Thanks to Maddy Adams for catching this)
@dgovil dgovil mentioned this issue Dec 18, 2023
Merged
2 tasks
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgovil @jesschimein