Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdSt fails to render EDF #3105

Closed
dgovil opened this issue Jun 3, 2024 · 1 comment
Closed

hdSt fails to render EDF #3105

dgovil opened this issue Jun 3, 2024 · 1 comment

Comments

@dgovil
Copy link
Collaborator

dgovil commented Jun 3, 2024

Description of Issue

We're attempting to add MaterialX support in Blender, and hitting this issue where ND_surface includes a EDF input. However , hdSt always fails with the following.

I've tried removing it from the output usda file, and it still seems to try and pick it up.
It looks like this is because the ND_standard_surface lofts up the EDF attribute and hdSt fails to deal with it. Instead of just ignoring it during the compile, it just outright fails.

Is there a workaround for this that anyone might know of in the meantime?

Warning: in _ValidateCompilation at line 229 of /Users/dhruvgovil/Projects/usd/pxr/imaging/hdSt/glslProgram.cpp -- Failed to compile shader (FRAGMENT_SHADER): program_source:1200:5: error: unknown type name 'EDF'
    EDF edf;
    ^

Warning: in _ValidateCompilation at line 229 of /Users/dhruvgovil/Projects/usd/pxr/imaging/hdSt/glslProgram.cpp -- Failed to compile shader (FRAGMENT_SHADER): program_source:1137:5: error: unknown type name 'EDF'
    EDF edf;
    ^

Warning: in _ValidateCompilation at line 229 of /Users/dhruvgovil/Projects/usd/pxr/imaging/hdSt/glslProgram.cpp -- Failed to compile shader (FRAGMENT_SHADER): program_source:2457:5: error: unknown type name 'EDF'
    EDF edf;
    ^

Warning: in _ValidateCompilation at line 229 of /Users/dhruvgovil/Projects/usd/pxr/imaging/hdSt/glslProgram.cpp -- Failed to compile shader (FRAGMENT_SHADER): program_source:2394:5: error: unknown type name 'EDF'
    EDF edf;
    ^

ERROR: Usdview encountered an error while rendering.
	Error in '&pxrInternal_v0_24__pxrReserved__::HdSt_DrawBatch::_GetDrawingProgram' at line 408 in file /Users/dhruvgovil/Projects/usd/pxr/imaging/hdSt/drawBatch.cpp : 'Failed to compile shader for prim /root/Plane/Plane.'
	Error in '&pxrInternal_v0_24__pxrReserved__::HdSt_DrawBatch::_GetDrawingProgram' at line 408 in file /Users/dhruvgovil/Projects/usd/pxr/imaging/hdSt/drawBatch.cpp : 'Failed to compile shader for prim /root/Sphere/Sphere.'

Steps to Reproduce

  1. Load the usda or mtlx file here in usdview, and look for the warnings in the terminal
    Diffuse Graphs.zip

System Information (OS, Hardware)

Happens on macOS and Linux

Package Versions

USD 24.3/24.5 with MaterialX 1.38.6 and MaterialX 1.38.10

dgovil added a commit to dgovil/USD that referenced this issue Jun 3, 2024
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants