[usdAbc] Relax type-checking on position property and let any float[3] type through. #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-5867 |
spiffmon
reviewed
Feb 19, 2020
There was a problem hiding this comment.
It's unfortunate Alembic doesn't give us any other matching options than "strict" or "none", but I guess we can be confident that no tool is writing points as integer or string arrays :-)
Change looks good to me - thanks, @marsupial !
|
@marsupial -- wondering why we didn't update _ReadCurves and _ReadPoints? Just an oversight, or is there a reason to keep the strict matching for those? |
|
No other reason than the asset that triggered this was a mesh only. |
|
Okay great, thanks @marsupial -- no worries, we can take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Older Alembics could have been written with .P as a Vec3f or even float[3].
Fixes Issue(s)
Resurrecting old/archived assets should just work with least amount of steps.