Clear primInfo->extraDependencies in _RemoveDependencies #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave been added to _dependenciesToRemove. Previously the contents of this set were never cleared, and removing many prims would add N copies of the N extrDependencies to the _dependenciesToRemove vector, chewing up enormous time and memory.
|
Filed as internal issue #USD-6014 |
|
After speaking to @c64kernal, this is the wrong way to go about addressing the underlying problem here. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear primInfo->extraDependencies in _RemoveDependencies after they have been
added to _dependenciesToRemove. Previously the contents of this set were never
cleared, and removing many prims would add N copies of the N extraDependencies
to the _dependenciesToRemove vector, chewing up enormous time and memory.
Description of Change(s)
The extraDependencies data on the UsdImagingDelegate::_HdPrimInfo object is currently never cleared. This change is an experiment requested by @c64kernal on #1170 to see if your internal regression tests still pass with this change in place. My testing in Houdini so far shows no ill effects from clearing this, and shows massive performance improvements when removing a mesh prim with many thousands of geometry subsets on it. I believe this change should be independent of whether PR 1170 (which changes extraDependencies from an SdfPathVector to a DenseHashSet) is applied.