usdMaya: warn if falling back to pseudoRoot due to failed primPath #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #147128. |
pixar-oss
added a commit
that referenced
this pull request
Jan 8, 2018
usdMaya: warn if falling back to pseudoRoot due to failed primPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Currently, when the maya plugin is passed an invalid primPath (either one that has bad syntax, like "bad;primPath", or one that doesn't exist in the scene, like "/prim/doesnt/exist"), the plugin silently just converts this to a pseudoRoot ("/"). I feel that it should, at minimum, print a warning - so I've made a commit / pull request that does that.
It think it would be still more preferable to have it "abort" and return false, similar to the behavior if the stage has an invalid defaultPrim (the handling of which is a few lines below). However, I was hesitant to change existing behavior without sanction. If returning false would be preferable, though, it's an easy addition.
Included Commit(s)
Fixes Issue(s)