Fix display of materials on instanceable prototype on point instancers. #1627
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for PixarAnimationStudios#1449 looks like it broke material bindings in the case where a point instancer prototype was marked as instanceable, but the material was bound inside the prototype (on an instance proxy). The bound material was being expressed with the instance proxy path instead of the prototype path, which is how the material is actually identified in hydra. So now the fix for PixarAnimationStudios#1449 is only applied to the instanceable prim, not the contained instance proxy prims. Fixes PixarAnimationStudios#1626
|
Filed as internal issue #USD-6908 |
|
Hey Mark, Do you have a failing example scene we can take a look at? That would help me think through the consequences of this change. Thanks, |
|
Yep, there is a file attached to #1626. |
|
Thanks as always for the great test cases :). I have an alternative fix that should be going into the pixar tree by EOD. |
|
@tcauchois 's fix e0da0a7, has been pushed to dev branch. Closing this PR in favor of that change. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The fix for #1449 looks like it broke material bindings in the case where
a point instancer prototype was marked as instanceable, but the material
was bound inside the prototype (on an instance proxy). The bound material
was being expressed with the instance proxy path instead of the prototype
path, which is how the material is actually identified in hydra. So now
the fix for #1449 is only applied to the instanceable prim, not the
contained instance proxy prims.
In my limited testing, this change seems to fix #1626 without breaking #1449.
But I don't understand this stuff deeply enough to really be sure this is right.
Fixes Issue(s)