Setting up the shading mode option menu dynamically. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirpalee
force-pushed
the
pr_dynamic_shading_mode_list
branch
from
4de0d52
to
5c57e4b
Compare
pixar-oss
added a commit
that referenced
this pull request
Apr 13, 2017
Setting up the shading mode option menu dynamically.
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…splay issue. (PixarAnimationStudios#166) Fix in TextSystem side: The reason is the text run is replaced by sub text runs and deleted, but the range of lines still save the old text run iterator. Remove recheckLines functions, and do similar things before the old text run is deleted after font substitution or divide. Add complex scripts test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The change builds the Shading Mode list dynamically, instead of hard coding the values in the Mel scripts. The advantage of this change is adding a new shading mode export won't require manual changes in the UI scripts, and the translatorMaterial will use the right exporter at export time.
To make this work, I needed to add a new command to list the export/import Shading Modes, similar functions to the Registry, and modify the UI scripts to build the optionMenu based on the output of the command.
Fixes Issue(s)
N/A