BakeSkinning: add support for skinning normals with faceVarying interpolation #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing interpolation.
|
Filed as internal issue #USD-7043 |
|
@cameronwhite Thanks for the change! To answer your first question - using a separate UsdSkelSkinFaceVaryingNormalsLBS() method instead of adding yet another override is probably ok in this case since this is about the caller facing api and internally they all end up calling _SkinNormalsLBS anyway. |
ucbearkat
reviewed
Jan 18, 2022
There was a problem hiding this comment.
@cameronwhite Sorry it took a while to get back to you on this.
This change is pretty great overall. Noted a couple comments that came up.
Thanks!
…lsLBS() - Add a GfMatrix3f overload for UsdSkelSkinFaceVaryingNormalsLBS(), refactoring the implementation into a templated function. - Use const where possible in _FaceVaryingPointIndexFn::GetPointIndex()
|
Thanks! I've pushed a commit with the noted changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Previously, only normals with vertex or varying interpolation were deformed. This was something we noticed while experimenting with using UsdSkel to deform fractured meshes from rigid body simulations, where faceted normals are quite common.
To reproduce, load the attached file with
usdview facevarying_normals.usda --camera /cameras/camera1, and then runUsdSkel.BakeSkinning(usdviewApi.stage.Traverse())in the interpreter. The undeformed normals can be seen as the cube spins around.A few notes:
UsdSkelSkinFaceVaryingNormalsLBS()method rather than more overloads ofUsdSkelSkinNormalsLBS()- feedback on this is welcome!