Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify mesh subdivision options in physics documentation #1948

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Clarify mesh subdivision options in physics documentation #1948

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3661b22
Add short explanitory note to physics collision shape generation.
eoineoineoin Jul 14, 2022
ed51b21
Clarify wording based on feedback.
eoineoineoin Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pxr/usd/usdPhysics/overview.dox
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,12 @@ a bounding sphere. If an implementation does not support a particular kind of
approximation, it is recommended that it falls back to the most similar
supported option.

Note that use of the subdivision attribute (\ref
UsdGeomMesh::GetSubdivisionSchemeAttr()) can cause features such as sharp
corners to be removed from the graphical representation. In order to ensure the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:
“corners and edges to be…”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout; thanks. Reworded that part.

physics representation accurately matches the graphical representation, this
attribute should be accounted for when generating physics colliders.

Collision meshes may be specified explicitly (for example one that was
processed by a particular decimator) by adding the custom collider mesh as a
sibling to the original graphics mesh, UsdGeomImageable _purpose_ to "guide" so
Expand Down