Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use literal true instead of 1 for bools. #1997

Merged

Conversation

waywardmonkeys
Copy link
Contributor

This fixes one class of warnings for the pxr/base code from clang-tidy.

  • I have submitted a signed Contributor License Agreement

@spiffmon
Copy link
Member

Hi @waywardmonkeys ,
Can you please submit your changes to lz4.cpp to the LZ4 gitHub repo? We are simply inlining it, and would not want to deviate except for a critical fix. Once it's been accepted there, it would make sense for us to incorporate it here. Thanks!

@sunyab
Copy link
Contributor

sunyab commented Aug 17, 2022

Filed as internal issue #USD-7561

@sunyab
Copy link
Contributor

sunyab commented Feb 10, 2023

I've merged the fix to the getenv.cpp internally and that'll get into the dev branch with the next push. I've skipped the change to LZ4 since that fix is more appropriate for the LZ4 repo itself.

@pixar-oss pixar-oss merged commit 1dc0403 into PixarAnimationStudios:dev Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants