APPLE: Fix OpenImageIO and OpenEXR debug libraries not found #2079
Conversation
slingthor
force-pushed
the
thor/dev/oiio_openexr_debug_mac
branch
from
993b040
to
8a5b901
Compare
|
Attempted to re-trigger the tests (initial run was a fault on my part), but after re-triggering they seem to be failing on startup. Is there any way to retry this? |
|
@slingthor I gave it a kick |
|
Filed as internal issue #USD-7742 |
| set(DEBUG_POSTFIX ) | ||
| if(DEFINED PXR_USE_DEBUG_BUILD) | ||
| if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND ${PXR_USE_DEBUG_BUILD} MATCHES ON) | ||
| set(DEBUG_POSTFIX _d) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
We are building a full debug and also building OpenEXR (and Alembic) statically. Locally I've added extra NAMES lines for debug and static. But I like your approach. When building OpenExr statically the libs are appended with "_s" and "_s_d". Could that be added here as well?
|
Per this issue #2231 the problem may extend into OpenVdb as well, in terms of needing to patch the OpenVdb find script, and also checking with the OpenVdb project to discover if the problem is fixed in a later revision. |
|
Please note @Ben1138's feedback from #2231, quoted below. This patch is necessary for Windows, and probably Linux as well for debug builds. Patching FindOpenEXR.cmake and build_usd.py as described in PR #2079 solved the issue of USD not finding OpenEXR. About OpenVDB, I just left it out (--no-openvdb). Now I got a successfull debug build! When I patched FindOpenEXR.cmake I left out the if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin" part, since I'm on Windows. |
APPLE: Fix OpenImageIO and OpenEXR debug libraries not found (Internal change: 2309779) (Internal change: 2309783)
Description of Change(s)
Modify build script to indicate to CMAKE we are building a debug build
If we are doing a debug build and we are doing a Mac build, append a postfix to correctly find the debug library files.
Fixes Issue(s)
Debug OpenImageIO / OpenEXR builds cannot be made on Apple platforms