Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python version to pxrConfig.cmake #2093

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

nicolaspopravka
Copy link
Contributor

Description of Change(s)

These proposed changes address the problem of how to configure another downstream cmake-based project that depends on USD, on systems with multiple versions of Python installed. The solution is to stash in the generated pxrConfig.cmake file the exact version used at build time, for the other projects to find, if possible. The build script can now help with that.

Fixes Issue(s)

  • find_package(Python) in pxrConfig.cmake may not find the correct version of Python for another downstream project to successfully build. To be correct, find_package(Python <version> EXACT) is needed, with <version> the version of Python that USD was built with.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@sunyab
Copy link
Contributor

sunyab commented Nov 19, 2022

Filed as internal issue #USD-7778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants