[USD] Include codegenTemplates in usdGenSchema. #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pal Mezei <palm@lumapictures.com>
|
Filed as internal issue #148278. |
5 tasks
|
Hi @sirpalee, I'd like to close this PR out in favor of commit 043ebbf. We were discussing this during the week and we prefer this solution because it allows external devs to run usdGenSchema from a distributed build but doesn't require extra code transformations at build time. Let us know if you think there's anything here we should reconsider. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The change includes codegenTemplates in usdGenSchema during the build process. If the codegenTemplates path does not exist, the code falls back to use the dictionary inside usdGenSchema.
This way external plugin devs can work with the installed usdGenSchema without manually copying codegenTemplates, and USD devs can keep working with usdGenSchema inside the source tree.
Fixes Issue(s)
#211