Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preprocessor usage in macros in pxr/base/tf #2320

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Mar 2, 2023

Description of Change(s)

  • The boost preprocessor usage in enum.h are replaced by simply passing the variadic arguments as std::string arguments. If there are no arguments, the macro expands to std::string{} which is the empty string (and equivalent to the default argument). Otherwise, the variadic arguments will be passed to the std::string constructor.
  • The boost preprocessor usage in scopeDescription.h are replaced with variadic templates. Forwarding overloads are provided for common string types to avoid needless construction of a new string when no formatting arguments are provided.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the tfnoboostpp branch 2 times, most recently from f1a99b9 to e285469 Compare March 3, 2023 03:51
@sunyab
Copy link
Contributor

sunyab commented Mar 14, 2023

Filed as internal issue #USD-8081

@pixar-oss pixar-oss merged commit 68755eb into PixarAnimationStudios:dev Jul 3, 2023
@nvmkuruc nvmkuruc deleted the tfnoboostpp branch December 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants