Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused boost headers from pch.h files #2323

Closed
wants to merge 1 commit into from

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Mar 3, 2023

Description of Change(s)

boost/mpl/or.hpp, boost/mpl/if.hpp, boost/mpl/and.hpp, boost/type_traits/is_signed.hpp, and boost/utility/in_place_factory.hpp are no longer used in the pxr code base and can be safely removed from all pch.h files.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the pchcleanup branch 3 times, most recently from 24c1a32 to a0bdec7 Compare March 3, 2023 21:17
@sunyab
Copy link
Contributor

sunyab commented Mar 14, 2023

Filed as internal issue #USD-8084

@spiffmon
Copy link
Member

spiffmon commented Mar 1, 2024

@nvmkuruc , we're going to close this in favor of rerunning our internal pch-generator script so we can be confident we'll continue to get the right results going forward. Thanks, though!

@spiffmon spiffmon closed this Mar 1, 2024
@nvmkuruc nvmkuruc deleted the pchcleanup branch May 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants